Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined entities are not reported for EPUB2 checks. #1546

Open
typopaul opened this issue Oct 9, 2023 · 2 comments
Open

Undefined entities are not reported for EPUB2 checks. #1546

typopaul opened this issue Oct 9, 2023 · 2 comments
Assignees
@rdeltour
Labels
status: waiting for feedback The development team needs feedback from the issue’s creator type: unverified The issue couldn't be reproduced
Milestone
Next maintenance ...

Comments

@typopaul
Copy link

typopaul commented Oct 9, 2023

Non-standard entities, for example &linkref; are not reported when the checked file is EPUB2.
In EPUB3 such entities are reported as errors.

Is there a certain reason for this behavior?
@rdeltour
Copy link
Member

If entities are defined in an external DTD, that would be valid in EPUB 2 (but not in EPUB 3).
Could you share a sample file to reproduce the issue?

@rdeltour rdeltour self-assigned this Oct 13, 2023
@rdeltour rdeltour added status: waiting for feedback The development team needs feedback from the issue’s creator type: unverified The issue couldn't be reproduced labels Oct 13, 2023
@typopaul
Copy link
Author

typopaul commented Nov 2, 2023

@rdeltour

Find attached a zip file with a sample file containing a "wrong" entity in an EPUB2 file and a screenshot from the Thorium Reader.
I understand that the entity should be associated with an external DTD/resource.
I am surprised that the EPUB Checker does not report it as an error but Thorium Reader does.

issue1546_sample-entity-error-EPUB2.zip

@rdeltour rdeltour added this to the Next maintenance release milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdeltour rdeltour

Labels
status: waiting for feedback The development team needs feedback from the issue’s creator type: unverified The issue couldn't be reproduced
Projects
None yet
Milestone
Next maintenance release
Development

No branches or pull requests
2 participants
@rdeltour @typopaul