Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is eddsa multikey implementation correct? #44

Open
rflechtner opened this issue Mar 21, 2024 · 0 comments
Open

Is eddsa multikey implementation correct? #44

rflechtner opened this issue Mar 21, 2024 · 0 comments

Comments

@rflechtner
Copy link

I'm confused by the implementation of the eddsa Multikey that this test suite assumes.
Both according to https://github.com/multiformats/multicodec/blob/master/table.csv and https://w3c-ccg.github.io/did-method-key/#signature-method-creation-algorithm the prefix for an ed25519 public key is 0xed, but the implementation here (incorrectly, I'd say?) assumes a prefix of 0xed, 0x01 resulting in a hard-coded assertion that did:key DIDs must begin with z6Mk. Can you clarify where this extra byte is coming from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant