Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to TSC, TS 5 and NodeNext #126

Merged
merged 22 commits into from Apr 29, 2023
Merged

feat: migrate to TSC, TS 5 and NodeNext #126

merged 22 commits into from Apr 29, 2023

Conversation

Raiden1411
Copy link
Collaborator

@Raiden1411 Raiden1411 commented Apr 27, 2023

Description

Closes (#124)

Additional Information

  • I read the contributing guide
  • I added documentation related to the changes made.
  • I added or updated tests related to the changes made.

Your ENS/address:


PR-Codex overview

This PR updates the project dependencies and switches from tsup to tsc for building.

Detailed summary

  • Updates several dependencies
  • Switches from tsup to tsc for building
  • Changes file extensions from .ts to .js for some imports
  • Adds import statements for some types
  • Adds a new type field to package.json files
  • Updates tsconfig.json files
  • Moves some files to a new test directory
  • Adds a new bench directory
  • Adds a new .changeset file
  • Other minor changes and cleanups

The following files were skipped due to too many changes: tsconfig.node.json, src/human-readable/types/index.ts, src/human-readable/runtime/index.ts, src/utils.ts, tsconfig.build.json, examples/useContractReads.ts, .github/actions/install-dependencies/action.yml, src/human-readable/runtime/signatures.ts, src/human-readable/parseAbiItem.test-d.ts, examples/useContractRead.ts, rome.json, scripts/updateVersion.ts, src/test/index.test.ts, src/human-readable/types/structs.ts, src/human-readable/parseAbiParameter.test-d.ts, src/human-readable/parseAbiParameters.test-d.ts, playground/trace.ts, src/human-readable/parseAbi.test-d.ts, .github/workflows/lock-issue.yml, src/utils.test-d.ts, src/human-readable/index.ts, dist/shiki-twoslash.esm.js, dist/shiki-twoslash.cjs.development.js, src/human-readable/parseAbiItem.test.ts, src/human-readable/errors/index.ts, src/human-readable/parseAbiParameter.test.ts, tsconfig.json, src/human-readable/parseAbiParameters.test.ts, examples/readContracts.ts, src/human-readable/runtime/utils.test.ts, src/human-readable/errors/signature.ts, .github/workflows/snapshot.yml, .github/workflows/on-pull-request.yml, src/index.ts, src/human-readable/parseAbi.ts, src/errors.ts, src/human-readable/parseAbiParameter.ts, src/human-readable/parseAbiParameters.ts, src/human-readable/parseAbiItem.ts, src/human-readable/runtime/structs.ts, src/human-readable/errors/abiParameter.ts, src/human-readable/runtime/utils.ts, .github/workflows/verify.yml, .github/workflows/on-push-to-main.yml, src/human-readable/types/utils.ts, src/human-readable/types/signatures.ts, scripts/prepublishOnly.ts, tsconfig.base.json, src/abi.ts, package.json, dist/shiki-twoslash.cjs.production.min.js, dist/shiki-twoslash.cjs.production.min.js.map, dist/shiki-twoslash.esm.js.map, dist/shiki-twoslash.cjs.development.js.map, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: c54a8f8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abitype ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2023 11:48pm

@socket-security
Copy link

socket-security bot commented Apr 27, 2023

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

⬆️ Updated Package Version Diff Added Capability Access +/- Transitive Count Publisher
typescript@5.0.4 4.9.4...5.0.4 None +0/-0 typescript-bot
vitepress-plugin-shiki-twoslash@0.0.6 0.0.4...0.0.6 None +4/-5 awkweb
ethers@6.3.0 6.0.5...6.3.0 None +2/-2 ricmoo
bun@0.5.9 0.5.7...0.5.9 None +0/-0 robobun
zod@3.21.4 3.20.6...3.21.4 None +0/-0 colinmcd94

🚮 Removed packages: @changesets/cli@2.26.0, lint-staged@12.5.0, tsup@6.6.3

@Raiden1411
Copy link
Collaborator Author

@tmm like we discussed I tried to make the changes to be as close as possible with viem. Could you please make sure that I didn't mess up anything?

@fubhy
Copy link

fubhy commented Apr 29, 2023

Niceeeeeeeeee :)

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@56228df). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head aae30eb differs from pull request most recent head c54a8f8. Consider uploading reports for the commit c54a8f8 to get more accurate results

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage        ?   99.23%           
=======================================
  Files           ?       39           
  Lines           ?     3808           
  Branches        ?      348           
=======================================
  Hits            ?     3779           
  Misses          ?       29           
  Partials        ?        0           

@tmm tmm merged commit 7ccc347 into main Apr 29, 2023
9 of 10 checks passed
@tmm tmm deleted the update-ts branch April 29, 2023 23:49
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants