Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eip165 abi #127

Merged
merged 4 commits into from Apr 29, 2023
Merged

feat: add eip165 abi #127

merged 4 commits into from Apr 29, 2023

Conversation

izayl
Copy link
Contributor

@izayl izayl commented Apr 29, 2023

Description

What changes are made in this PR? Is it a feature or a bug fix?

Additional Information

  • I read the contributing guide
  • I added documentation related to the changes made.
  • I added or updated tests related to the changes made.

Your ENS/address: izayl.eth


PR-Codex overview

This PR adds support for EIP-165 to the abitype library, along with other minor changes and improvements.

Detailed summary

  • Added EIP-165 abi to src/test/abis.ts and src/test/human-readable.ts
  • Renamed address export to zeroAddress in src/test/index.ts, examples/watchContractEvent.test-d.ts, examples/useContractReads.test-d.ts, and examples/readContracts.test-d.ts
  • Updated imports in src/utils.test-d.ts and examples/readContract.test-d.ts to use zeroAddress instead of address

The following files were skipped due to too many changes: examples/readContract.test-d.ts, examples/useContractRead.test-d.ts, examples/writeContract.test-d.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2023

🦋 Changeset detected

Latest commit: 1a0f3d7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
abitype ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2023 9:33pm

@commit-lint
Copy link

commit-lint bot commented Apr 29, 2023

Features

Code Refactoring

  • rename address to zeroAddress (490f0e4)

Chore

Bug Fixes

Contributors

izayl, Raiden1411

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@Raiden1411
Copy link
Collaborator

Looks good. Could you add a changeset? Also, would you mind changing the name address to zeroAddress so that we have the same as viem?

@Raiden1411 Raiden1411 merged commit a71c5ce into wevm:main Apr 29, 2023
9 checks passed
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants