fix: return undefined from mine() instead of null to match inte…

…rface
wevm · Apr 26, 2023 · eb32e6c · eb32e6c · vercel · Apr 26, 2023
1 parent 43867af
commit eb32e6c
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/lovely-steaks-hear.md b/.changeset/lovely-steaks-hear.md
@@ -0,0 +1,5 @@
+---
+"viem": patch
+---
+
+Fixed `mine()` to resolve to `undefined` instead of `null`.
diff --git a/src/actions/test/mine.ts b/src/actions/test/mine.ts
@@ -37,7 +37,7 @@ export async function mine<TChain extends Chain | undefined>(
   client: TestClient<TestClientMode, Transport, TChain>,
   { blocks, interval }: MineParameters,
 ) {
-  return await client.request({
+  await client.request({
     method: `${client.mode}_mine`,
     params: [numberToHex(blocks), numberToHex(interval || 0)],
   })

diff --git a/src/clients/decorators/test.test.ts b/src/clients/decorators/test.test.ts
@@ -87,7 +87,7 @@ describe('smoke test', () => {
   })
 
   test('mine', async () => {
-    expect(await testClient.mine({ blocks: 1 })).toBeDefined()
+    expect(await testClient.mine({ blocks: 1 })).toBeUndefined()
   })
 
   test('removeBlockTimestampInterval', async () => {