refactor: remove defineChain export #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e0b22e8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fubhy
force-pushed
the
refactor/move-definechain
branch
from
0dcc4a4
to
e0b22e8
Compare
|
Size Change: -66 B (0%) Total Size: 252 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #424 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 267 267
Lines 22655 22654 -1
Branches 1925 1924 -1
=======================================
- Hits 22640 22639 -1
Misses 15 15
|
|
This is technically a breaking change. Don't think anyone would be using it yet though. Maybe we can move the export to the root entrypoint? |
Yeah. I think it's better to do this now than later. Also, it's a very small breaking change considering that all you'd have to do to update is to change the import. I'll add it to \Wait... It already is in the root entrypoint! |
|
Yeah, so imho this would be ready then? Unless I'm missing sth. :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR removes the
defineChainexport fromviem/chainsand removesdefineChainimport from multiple files.Detailed summary
defineChainexport fromviem/chains.defineChainimport fromsrc/chains.ts.defineChainimport fromsrc/actions/wallet/sendTransaction.test.ts.