Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(constants): add zeroAddress #426

Merged
merged 3 commits into from Apr 29, 2023
Merged

Conversation

izayl
Copy link
Contributor

@izayl izayl commented Apr 27, 2023

PR-Codex overview

This PR adds a new constant zeroAddress to the constants module.

Detailed summary

  • Added zeroAddress constant to constants module.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: a91843c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 27, 2023

@izayl is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@jxom
Copy link
Member

jxom commented Apr 27, 2023

Might be worth adding it as an export to src/index.ts too.

@Raiden1411
Copy link
Contributor

Abitype already export this in "abitype/test" could possible make sense in using that and exporting in viem too.

Reference

@izayl
Copy link
Contributor Author

izayl commented Apr 29, 2023

@Raiden1411 thanks for you remind, but I think export direct from viem may be more reasonable.
@jxom What do you think about it? if it should from abitype, I can help update the abitype repo for renaming address to zeroAddress

@jxom jxom merged commit 840d19d into wevm:main Apr 29, 2023
3 of 4 checks passed
@github-actions github-actions bot mentioned this pull request Apr 29, 2023
@izayl izayl deleted the feature/zero-address branch April 29, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants