feat: ccip read #427
Merged
feat: ccip read #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7188d48 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +5.17 kB (+2%) Total Size: 257 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
========================================
Coverage 99.93% 99.93%
========================================
Files 267 269 +2
Lines 22655 22895 +240
Branches 1924 1959 +35
========================================
+ Hits 22641 22881 +240
Misses 14 14
|
tmm
reviewed
Apr 29, 2023
src/errors/request.ts
Outdated
| ].filter(Boolean) as string[], | ||
| }) | ||
| this.body = body | ||
| if (body) this.body = body |
There was a problem hiding this comment.
body undefined if not provided so seems correct the way it was before.
Suggested change
| if (body) this.body = body | |
| this.body = body |
| @@ -159,6 +161,9 @@ export async function call<TChain extends Chain | undefined>( | |||
| if (response === '0x') return { data: undefined } | |||
| return { data: response } | |||
| } catch (err) { | |||
| const data = getRevertErrorData(err) | |||
| if (data?.slice(0, 10) === offchainLookupSignature && to) | |||
| return { data: await offchainLookup(client, { data, to }) } | |||
Comment on lines
+33
to
+36
| const { args } = decodeErrorResult({ | ||
| data, | ||
| abi: [offchainLookupAbiItem], | ||
| }) as unknown as GetErrorArgs< |
There was a problem hiding this comment.
Unrelated to this PR: Wonder if it's worth adding an optional errorName property to decodeErrorResult that narrows the return type and adds some runtime validation. Could also make DecodeErrorResultReturnType generic and return union of possible errors if errorName isn't provided.
src/utils/ccip.ts
Outdated
| const [sender, urls, callData, callbackSelector, extraData] = args | ||
|
|
||
| try { | ||
| if (to.toLowerCase() !== sender.toLowerCase()) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR adds support for EIP-3668 CCIP Read and introduces an
OffchainLookupExamplecontract. It also exportsOffchainLookupand related functions, and adds several error classes for handling offchain lookup errors.Detailed summary
OffchainLookupExamplecontract.OffchainLookupand related functions.