-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
peer-exchange browser feedback #1454
Comments
After some time I got. Peers Discovered: 126 and only WSS errors. |
Correct. This is the idea. The idea right now is to just to gauge the % success in the number of connections we can make. Thanks for the feedback! |
@mfw78 what's the setup on dappnode? I see some |
I am getting
Despite node connections being quite low: https://grafana.infra.status.im/d/qrp_ZCTGz/nim-waku-v2?orgId=1&refresh=30s&var-host=node-.%2A&var-fleet=wakuv2.test&var-fleet=wakuv2.prod&var-dc=All&from=now-2d&to=now&viewPanel=2&editPanel=2 And again (my peer id:
|
Same in Brave:
|
Something changed on the fleet/node side. I was able to connect with the node last week
|
|
Update: this issue is now resolved from nwaku side. |
Fair but is nwaku in dappnode configured so that it advertised itself using the wss proxy multiaddr and NOT the ws one? looks like it's not always the case (advertise ws instead of wss). |
@fryorcraken
this issue imo should not be a blocker, but parallel work to be done, for the milestone: #1429 |
Regarding dappnode, we can open an orphan issue for now and track with @mfw78 to understand what can be done. What is the second issue about? I'd suggest we investigate a bit more before considering peer exchange as done. |
Some more feedback:
|
Interestingly enough this is a fleet peer used as a rendezvous peer:
I think. Is that even the correct multiaddr format for rendezvous? cc @richard-ramos Not sure it makes sense to dial rendezvous peers for filter purposes. I wonder if it means that the 90+ nodes we are discovering are actually Status Desktop nodes reachable via rendezvous. This would make sense. |
Actually, if js-waku can connect to a Status desktop node via a fleet node thanks to While the js-waku node would still hog a connection on the fleet ( In terms of privacy, it would also mean that the fleet would not know the messages being sent by js-waku node, and may not know content topics of interest (except if store is used on fleet node). @richard-ramos @waku-org/research is my analysis correct? |
Note that support for Edited. |
That is a very nice idea @fryorcraken . This way the load of light clients can be distributed to the nodes in the network rather than just the fleets making it more decentralized. Wrt connection, same libp2p connection will be reused for multiple protocols as it is the same peer. |
Agree here that connecting to distributed nodes for filter and lightpush is beneficial. Currently Status Desktop nodes do the same. What I'm confused about is why this necessarily has to be discovered via rendezvous? Status Desktop nodes are discoverable in most cases via discv5 and peer exchange. For now, we suggest peer exchange as better discovery mechanism than rendezvous, as it's less prone to neighbourhood-effects. Rendezvous is useful to discover nodes behind a NAT and coordinating a hole punch. |
This is not a correct multiaddress format as it is missing the |
yeah, libp2p does stream multiplexing, so a single connection can be reused for multiple protocols |
@jm-clius my bad, wherever I said "rendezvous" I actually meant "p2p-circuit" Thanks @richard-ramos for jumping in.
Maybe older Status Desktop versions? Would be good to see if we successfully find and connect to p2p-circuit addresses via peer exchange cc @danisharora099 |
@danisharora099 let me know if i can help. FWIW the go-waku test/prod fleets should have circuit relay enabled so maybe they can be used to force an scenario win which p2p circuit addresses appear in peer exchange. |
Thanks everyone for the feedback!
no. they are all the peers received through the event emitter. |
I think so. But maybe once we get p2p-circuit (confirmed) working |
This PR is meant to track the feedback and dial errors encountered via peer exchange on browser using the web-chat example, and is part of the milestone #1429 and #1326
Related:
The text was updated successfully, but these errors were encountered: