Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Instruction Improvements #46

Open
machineghost opened this issue Dec 15, 2016 · 2 comments
Open

Possible Instruction Improvements #46

machineghost opened this issue Dec 15, 2016 · 2 comments

Comments

@machineghost
Copy link

machineghost commented Dec 15, 2016

Hello. I've been comparing React-based date and time pickers, and input-moment looks to be the best. However, getting up to speed with it could be a little easier. If you ...

  1. Included an import or require line in the readme.md instructions code; without this one doesn't know whether to do import InputMoment from 'input-moment' or import {InputMoment} from 'input-moment'

  2. Mention the CSS requirements (and how to fulfill them); right now there's no mention of the CSS on the readme.md, but obviously the CSS is pretty important to the library

Thanks for making input-moment!

@wangzuo
Copy link
Owner

wangzuo commented Dec 16, 2016

Thank you for all your feedbacks, will try to fix those issues.

@aikar
Copy link

aikar commented Feb 24, 2017

Since node_modules is commonly ignored in webpack, i would suggest including this as the example for CSS

require("style-loader!css-loader!input-moment/dist/input-moment.css");

for webpack users, to ensure it gets loaded the same way w/o the need to add exclusions in your webpack config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants