[1.24.1] Command is run multiple times

[tminich]

After updating to 1.24.0/1.24.1 it seems like the command is run for each event rather than once for each batch. I hadn't used debounce so far, but even that doesn't help (technically in my case makes it even worse, as I'm running a directory sync that now runs several times at once conflicting).

OS: Windows
Command line:

watchexec -w "C:\devel\laravel" --project-origin "C:\devel\laravel" --no-default-ignore --no-vcs-ignore --no-project-ignore --no-global-ignore --no-meta -d 2 --ignore-file "C:\devel\exclude.watchexec" <command>

[passcod]

I'll look into this but as an aside you can replace --no-default-ignore --no-vcs-ignore --no-project-ignore --no-global-ignore with --ignore-nothing. Note that -d with a unitless value interprets it as milliseconds, so indeed that might be worse than the default (50ms).

[tminich]

Ah, I missed that, thanks. Trying now with a sane value =)
Nevertheless, no matter what your review yields, might be worth to consider implementing at least two execution modes, one that ensures the command never runs in parallel and one that runs the command for every update.

[tminich]

Looks good now. I suspect between versions timings subtly changed and the debounce default was fine before but now caused issues?

[passcod]

one that ensures the command never runs in parallel and one that runs the command for every update.

That should already be the case, unless there's a race condition very early, there's no way for current Watchexec to have two simultaneous runs of a process unless the command is detaching itself (in which case Watchexec is no longer in control of it).

In fact the current default is for events received during a run to queue up a subsequent run when the current one stops. You may want --on-busy-update=do-nothing to ignore changes while the command is currently running instead.

[tminich]

Then indeed something seems to be wrong, the command ran multiple times in parallel. The way you describe the intended default behavior is exactly how I want it to run: if something triggers during a run, finish the run and then run again (once).

[passcod]

Well, that's annoying, but at this point I need your command, or something like your command that behaves the same if there's privacy issues here, to replicate this. And if possible, a logfile at -vvv level or higher.

[tminich]

rclone.exe sync -M -v --local-no-preallocate --local-no-sparse --exclude .env --fast-list --exclude-from C:\devel\exclude.rclone C:\devel\laravel \\WSL$\UBUNTU-22.04\home\tminich\devel\laravel

I cut the paths down a bit, but that shouldn't matter. Any somewhat sizable repository as a sync source should work.

[passcod]

Aight, got a reproduction, I'll get a fix out soon

[tminich]

Thanks, I'll check when I'm back at work early January.