Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix queueing behaviour #734

Merged
merged 3 commits into from Dec 19, 2023
Merged

Fix queueing behaviour #734

merged 3 commits into from Dec 19, 2023

Conversation

passcod
Copy link
Member

@passcod passcod commented Dec 19, 2023

Two-parter:

  • Supervisor's Start behaviour was wrong, and
  • CLI would queue more than one starts on busy change

Fixes #726

Some refactor ago, that was handled by CommandState.spawn() itself, but
then that was taken out; unfortunately that logic wasn't put in Start's
handling at that time.

Also enable kill-on-drop to avoid ever having multiple processes in flight.
@passcod passcod enabled auto-merge (squash) December 19, 2023 11:11
@passcod passcod merged commit eb4f2ce into main Dec 19, 2023
8 checks passed
@passcod passcod deleted the queueing-fixes branch December 19, 2023 11:23
This was referenced Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.24.1] Command is run multiple times
1 participant