Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]Add support for secret annotation so only annotated secrets trigger rolling update #113

Open
johnphilipscs opened this issue Oct 29, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@johnphilipscs
Copy link

I am using your controller to trigger our app to perform a rolling update when cert-manager renews a certificate. It is my preference to restrict the trigger to only occur on the particular certificate secret and not on changes to other secrets.

@johnphilipscs johnphilipscs changed the title [Feature Request]Add support secret annotation so only annotated secrets trigger rolling update [Feature Request]Add support for secret annotation so only annotated secrets trigger rolling update Oct 29, 2021
@github-actions
Copy link

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

@github-actions github-actions bot added the Stale label Dec 29, 2021
@johnphilipscs
Copy link
Author

Still interested in this feature if anyone is working on this project.

@github-actions github-actions bot closed this as completed Jan 7, 2022
@toelke toelke added enhancement New feature or request and removed Stale labels Feb 12, 2024
@toelke toelke reopened this Feb 12, 2024
@jabdoa2
Copy link
Contributor

jabdoa2 commented Apr 27, 2024

I guess ideally this annotations would be on the deployment side instead of the secret side. Otherwise, you might disable it for multiple deployments at once. We could create some kind of whitelist or blacklist annotation on the deployment. What do you think?

@jabdoa2
Copy link
Contributor

jabdoa2 commented May 3, 2024

@toelke do we want to support this?

Options:

  1. Support wave.pusher.com/update-on-config-change: "only-annotated" on Deployments. Add wave.pusher.com/update-deployment-on-config-change: "true" to Secrets/CMs.
  2. Add a flag to wave to change the default behavior. Add wave.pusher.com/update-deployment-on-config-change: "true" to Secrets/CMs.
  3. Add wave.pusher.com/ignore: "true" to Secrets/CMs to selectively ignore Secrets/CMs. (Kind of different from the request)
  4. Decide not to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants