Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

E2e tests failing after ghet based auto-install of golangci-lint #43

Closed
cardil opened this issue Mar 20, 2024 · 2 comments
Closed

E2e tests failing after ghet based auto-install of golangci-lint #43

cardil opened this issue Mar 20, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@cardil
Copy link
Member

cardil commented Mar 20, 2024

The 14874f0 added the auto-install of golangci-lint, using ghet, and new knative.dev/client-pkg/pkg/output/tui package.

This caused the tests to fail on CI, and hang when running on a dev machine. Here's a thread dump from hanging tests: https://gist.github.com/cardil/039c0691d94b9537126b50361bbf9d3e

@cardil
Copy link
Member Author

cardil commented Mar 21, 2024

This is most likely caused by knative/client-pkg#160 and knative/client-pkg#161

After resolving the above issues, the test still fails with:

[MAGE] 🔨 Building
[MAGE] 🔨 › 💿 dummy
[MAGE] 🔨 💿 dummy have failed: ko failed: build: go build: exit status 1: # runtime/cgo
cc1: error: bad value ‘z196’ for ‘-march=’ switch
cc1: note: valid arguments to ‘-march=’ switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client rocketlake icelake-server cascadelake tigerlake cooperlake sapphirerapids emeraldrapids alderlake raptorlake meteorlake graniterapids graniterapids-d bonnell atom silvermont slm goldmont goldmont-plus tremont sierraforest grandridge knl knm x86-64 x86-64-v2 x86-64-v3 x86-64-v4 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 lujiazui k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 znver3 znver4 btver1 btver2 native

[MAGE] 🔨 Building have failed!
Error: 2 errors occurred:
	* ko failed: build: go build: exit status 1: # runtime/cgo
cc1: error: bad value ‘z196’ for ‘-march=’ switch
cc1: note: valid arguments to ‘-march=’ switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client rocketlake icelake-server cascadelake tigerlake cooperlake sapphirerapids emeraldrapids alderlake raptorlake meteorlake graniterapids graniterapids-d bonnell atom silvermont slm goldmont goldmont-plus tremont sierraforest grandridge knl knm x86-64 x86-64-v2 x86-64-v3 x86-64-v4 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 lujiazui k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 znver3 znver4 btver1 btver2 native

	* ko failed: build: go build: exit status 1: # runtime/cgo
cc1: error: bad value ‘z196’ for ‘-march=’ switch
cc1: note: valid arguments to ‘-march=’ switch are: nocona core2 nehalem corei7 westmere sandybridge corei7-avx ivybridge core-avx-i haswell core-avx2 broadwell skylake skylake-avx512 cannonlake icelake-client rocketlake icelake-server cascadelake tigerlake cooperlake sapphirerapids emeraldrapids alderlake raptorlake meteorlake graniterapids graniterapids-d bonnell atom silvermont slm goldmont goldmont-plus tremont sierraforest grandridge knl knm x86-64 x86-64-v2 x86-64-v3 x86-64-v4 eden-x2 nano nano-1000 nano-2000 nano-3000 nano-x2 eden-x4 nano-x4 lujiazui k8 k8-sse3 opteron opteron-sse3 athlon64 athlon64-sse3 athlon-fx amdfam10 barcelona bdver1 bdver2 bdver3 bdver4 znver1 znver2 znver3 znver4 btver1 btver2 native

unexpected error
exit status 1

@cardil
Copy link
Member Author

cardil commented Mar 28, 2024

The error described in #43 (comment) was just caused by running this test within Intellij provided by flatpak containerization.

Tests have been fixed commits. See, the status of 2b7c19f

@cardil cardil closed this as completed Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant