Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto_commit input #438

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Add auto_commit input #438

merged 3 commits into from
Apr 14, 2022

Conversation

Gismo359
Copy link
Contributor

@Gismo359 Gismo359 commented Apr 13, 2022

Adds auto_commit to prevent commits when auto_fix is enabled.

This allows someone to do this:

- name: Run linters
  uses: wearerequired/lint-action@master
  with:
    auto_fix: true
    auto_commit: false
    mypy: true
    mypy_args: >
      --follow-imports=silent
      --ignore-missing-imports
      --implicit-optional
      --no-strict-optional
    autopep8: true
    autopep8_args: >
      --max-line-length 120
- name: suggester / lint
  uses: reviewdog/action-suggester@v1
  with:
    tool_name: lint

which gives you the mypy messages from lint-action but with the autopep8 changes as suggested changes via reviewdog.

Pretty much resolves #436 as it can be achieved through reviewdog.

@Gismo359 Gismo359 closed this Apr 13, 2022
@Gismo359 Gismo359 reopened this Apr 13, 2022
Copy link
Member

@ocean90 ocean90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! What do you think about naming the option just commit? Or to be more explicit commitAndPush?

README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
Gismo359 and others added 2 commits April 13, 2022 19:31
Co-authored-by: Dominik Schilling <dominikschilling+git@gmail.com>
@ocean90 ocean90 merged commit fb64e3a into wearerequired:master Apr 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report format diffs as suggested changes
2 participants