Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating map controls and attribution #1217

Merged
merged 3 commits into from
May 20, 2024

Conversation

partly-igor
Copy link
Collaborator

What does this PR do? 🛠️

This PR resolves #1192 adding an isolation style to the map to fix the issue of the map controls and attribution floating above the tab container.

Screenshots (if appropriate): 📸

Screenshot of the map zoom controls going under the tab container
Screenshot of the map attribution going under the tab container

Also remove unintended shadow on map element
Copy link
Contributor

This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file?

Comment on lines +283 to +285
.isolation-isolate {
isolation: isolate;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. TIL.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah whoa

@partly-igor partly-igor merged commit 8b39204 into main May 20, 2024
13 of 14 checks passed
@partly-igor partly-igor deleted the ik/1192-alert-map-controls-stack branch May 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert map controls float over other content
3 participants