Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitopsClusters should only be Ready if "ClusterConnected is Ready too" #3200

Open
foot opened this issue Aug 11, 2023 · 2 comments · May be fixed by weaveworks/cluster-controller#56
Open

GitopsClusters should only be Ready if "ClusterConnected is Ready too" #3200

foot opened this issue Aug 11, 2023 · 2 comments · May be fixed by weaveworks/cluster-controller#56
Labels
area/cluster-mgmt team/pesto

Comments

@foot
Copy link
Collaborator

foot commented Aug 11, 2023

  • No secret: Ready=False, Message=No secret
  • Secret but not connected: Ready=False, Message=No connectivity
  • Secret and Connected: Ready=True!
@foot
Copy link
Collaborator Author

foot commented Aug 11, 2023

Somewhere in here https://github.com/weaveworks/cluster-controller/blob/main/controllers/gitopscluster_controller.go#L101

@sarataha sarataha self-assigned this Aug 11, 2023
@sarataha sarataha linked a pull request Aug 16, 2023 that will close this issue
Open
@foot
Copy link
Collaborator Author

foot commented Dec 6, 2023

@bigkevmcd do you think we still want to tackle this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cluster-mgmt team/pesto
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GitopsClusters should only be Ready if ClusterConnected is Ready too weaveworks/cluster-controller
3 participants
@foot @LappleApple @sarataha