Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Windows integration test runtime down to less than half #6965

Merged
merged 1 commit into from Aug 16, 2023

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Aug 16, 2023

Description

This changelist parallelises the Windows integration test specs by modifying the integration test runner to accept arbitrary arguments to be passed to the ginkgo binary, allowing the integration test GitHub workflow to pass the -p and --procs arguments to parallelise running the test specs. This has brought the total runtime of Windows integration tests down to ~55 minutes from ~2 hours and 30 minutes.

The cluster version used in the tests has been updated to the latest EKS version 1.27, and as a result, one of the tests that uses the Docker runtime has been removed as it's no longer supported.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 added area/testing area/tech-debt Leftover improvements in code, testing and building area/ci labels Aug 16, 2023
This changelist parallelises the Windows integration test specs by modifying the integration test runner to accept arbitrary arguments to be passed to the `ginkgo` binary, allowing the integration test GitHub workflow to pass the `-p` and `--procs` arguments to parallelise running the test specs. This has brought the total runtime of Windows integration tests down to ~55 minutes from ~2 hours and 30 minutes.

The cluster version used in the tests has been updated to the latest EKS version 1.27, and as a result, one of the tests that uses the Docker runtime has been removed as it's no longer supported.
@cPu1 cPu1 merged commit 2e9d27a into eksctl-io:main Aug 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/tech-debt Leftover improvements in code, testing and building area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants