Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message for Bottlerocket validation #6967

Merged
merged 1 commit into from Aug 17, 2023
Merged

Fix error message for Bottlerocket validation #6967

merged 1 commit into from Aug 17, 2023

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Aug 17, 2023 •
edited

Description

Closes #6933

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 added the kind/bug label Aug 17, 2023
@cPu1 cPu1 force-pushed the bottlerocket-error-message branch 2 times, most recently from 1882561 to 11894ae Compare August 17, 2023 08:09
@cPu1 cPu1 marked this pull request as ready for review August 17, 2023 08:09
@cPu1 cPu1 force-pushed the bottlerocket-error-message branch from 11894ae to 96400b7 Compare August 17, 2023 08:10
@cPu1 cPu1 force-pushed the bottlerocket-error-message branch from 283d626 to 6ab2911 Compare August 17, 2023 10:31
@cPu1 cPu1 enabled auto-merge August 17, 2023 10:31
@cPu1 cPu1 merged commit d364807 into eksctl-io:main Aug 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiberiuGC TiberiuGC TiberiuGC approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect error message in Bottlerocket nodegroup validation
2 participants
@cPu1 @TiberiuGC