Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STS interface #7345

Merged
merged 1 commit into from Dec 1, 2023
Merged

Fix STS interface #7345

merged 1 commit into from Dec 1, 2023

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Dec 1, 2023

Description

Removes code generation for the AWS STS interface in favour of a smaller interface that contains only the methods being consumed. Rather than trying to work around the issue with ifacemaker, this removes the need to use it for generating the STS interface.

Closes #7344

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 merged commit 9e72f57 into eksctl-io:main Dec 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate-aws-interfaces.sh imports the wrong module in the generated interfaces
2 participants