Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Update: Correct IAM Pod Identity Example Link #7376

Merged
merged 1 commit into from Dec 8, 2023

Conversation

chasestech
Copy link
Contributor

@chasestech chasestech commented Dec 7, 2023

Description

This updates a link in the Pod IAM Identity documentation to correctly reference the example provided in GitHub

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello chasestech 馃憢 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Thanks.

@cPu1 cPu1 enabled auto-merge December 8, 2023 07:13
@cPu1 cPu1 added the kind/docs User documentation label Dec 8, 2023
@cPu1 cPu1 merged commit 5ae372b into eksctl-io:main Dec 8, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs User documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants