Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ubuntu 22.04 based EKS images #7516

Merged
merged 1 commit into from Feb 9, 2024

Conversation

toabctl
Copy link
Contributor

@toabctl toabctl commented Jan 30, 2024

Ubuntu switched to 22.04 (Jammy) based images for EKS >= 1.29 . Add support for that here.

Description

Ubuntu EKS images from EKS 1.29 on are based on Ubuntu 22.04 (Jammy). This PR does add support for the new ubuntu2204 AMI family so eksctl can be used to generate EKS 1.29 clusters with Ubuntu images.

Checklist

  • Added tests that cover your change (based on the existing tests available for other ubuntu ami families)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested (via ./eksctl create cluster --node-ami-family Ubuntu2204 --version 1.29)
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello toabctl 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@toabctl toabctl force-pushed the ubuntu-22.04-support branch 2 times, most recently from 75ce2ae to 687b922 Compare January 30, 2024 10:11
@yuxiang-zhang yuxiang-zhang added the kind/feature New feature or request label Jan 31, 2024
@tanvp112
Copy link

tanvp112 commented Feb 8, 2024

Hi @yuxiang-zhang , any idea when can we get this release?

@yuxiang-zhang
Copy link
Member

@toabctl Thanks so much for making this update! Do you have any clues why there aren't any 1.29 images listed on https://cloud-images.ubuntu.com/aws-eks/?

@tanvp112 I will try to prioritize this for tomorrow, if not it'll go out next week. 🙏

Copy link
Member

@yuxiang-zhang yuxiang-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes lgtm 👍 I'll run through a manual test too.

One small comment, there is this change missing:

fs.StringVar(&ng.AMIFamily, "node-ami-family", api.DefaultNodeImageFamily, "'AmazonLinux2' for the Amazon EKS optimized AMI, or use 'Ubuntu2004' or 'Ubuntu1804' for the official Canonical EKS AMIs")

@toabctl
Copy link
Contributor Author

toabctl commented Feb 9, 2024

The changes lgtm 👍 I'll run through a manual test too.

One small comment, there is this change missing:

fs.StringVar(&ng.AMIFamily, "node-ami-family", api.DefaultNodeImageFamily, "'AmazonLinux2' for the Amazon EKS optimized AMI, or use 'Ubuntu2004' or 'Ubuntu1804' for the official Canonical EKS AMIs")

fixed

Ubuntu switched to 22.04 (Jammy) based images for EKS >= 1.29 . Add
support for that here.
@yuxiang-zhang yuxiang-zhang merged commit 0415323 into eksctl-io:main Feb 9, 2024
10 checks passed
@toabctl toabctl deleted the ubuntu-22.04-support branch February 12, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants