Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract common workflow steps to set up build environment #7551

Merged
merged 3 commits into from
Feb 14, 2024

Conversation

yuxiang-zhang
Copy link
Member

Description

Many workflow files share the same set of steps to set up the build environment. Every update in these places require making changes to 9 workflows at once. This PR extracts some common steps to a separate composite action.

This PR also remove the now inaccessible Slack notifications posted to Weave Slack channels.

This PR also closes #7491 which bumps actions/cache from 3.3.2 to 4.0.0.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@yuxiang-zhang yuxiang-zhang added dependencies Pull requests that update a dependency file area/tech-debt Leftover improvements in code, testing and building area/ci labels Feb 14, 2024
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thank you!

@yuxiang-zhang yuxiang-zhang merged commit d07f0c3 into eksctl-io:main Feb 14, 2024
9 checks passed
@yuxiang-zhang yuxiang-zhang deleted the extract-setup-build branch February 14, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/tech-debt Leftover improvements in code, testing and building dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants