Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Update the "View Pull Requests" to support multi-repo #2466

Closed
foot opened this issue Feb 27, 2023 · 3 comments · Fixed by #2566
Closed

[UI] Update the "View Pull Requests" to support multi-repo #2466

foot opened this issue Feb 27, 2023 · 3 comments · Fixed by #2566
Assignees

Comments

@foot
Copy link
Collaborator

foot commented Feb 27, 2023

Options:

  • Hard code link in the config
  • GET gitrepo sources (would require calling ParseRepoURL on each URL to determine if github/gitlab, but we could move that that GIT_HOST_TYPES config so the UI can see it and use it w/out having to query the BE)
    • Instead of calling const { provider } = parseRepoURL, lets look for the provider in the GitRepo annotations instead.
    • If github.com -> provider is github, if gitlab.com, then provider is gitlab, otherwise check anno?
@foot
Copy link
Collaborator Author

foot commented Feb 27, 2023

How do we do the URL here?
image

@ahussein3
Copy link
Contributor

@foot We are using this npm Package which have this open issue. And yes actually we are facing the same issue here. Do you think we should look for a substitute? Or we Should Fork and Fix ourselves like Here .
Let me know what you think.

@foot
Copy link
Collaborator Author

foot commented Mar 20, 2023

Maybe we can use a simpler but working lib like urijs e.g. mentioned here Rookout/parse-path#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants