Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloning a repo relies on settings in the user's environment #1100

Closed
jpellizzari opened this issue Nov 18, 2021 · 2 comments
Closed

Cloning a repo relies on settings in the user's environment #1100

jpellizzari opened this issue Nov 18, 2021 · 2 comments
Labels
bug Something isn't working severity/high low < medium < high < critical

Comments

@jpellizzari
Copy link
Contributor

Describe the bug
Cloning a repo complains about knownhosts: key mismatch

To Reproduce
Steps to reproduce the behavior:

  1. Add an app after the GitHub deprecation of certain ssh keys

Expected behavior
The app gets added using the ssh keys stored on the cluster

Additional context
Slack thread: https://weaveworks.slack.com/archives/C0140SWQ94M/p1637258875492700

go-git issue: go-git/go-git#411

Possible fixes:

  1. Fix the bug in go-git
  2. Ensure we have an known_hosts file in the docker container that the app runs in

This will be problematic because it will be to change that known_hosts file in the docker container if we have to.

OR

Use go-git-providers for all repo ops since that does not clone the repo, but instead uses the providers' HTTP API to do operations.
@jpellizzari jpellizzari added the bug Something isn't working label Nov 18, 2021
@rokshana-b rokshana-b added the severity/high low < medium < high < critical label Dec 1, 2021
@jpellizzari jpellizzari mentioned this issue Jan 5, 2022
Closed
@J-Thompson12
Copy link
Contributor

Related to #1278

@jpellizzari
Copy link
Contributor Author

Closing. We are sticking with go-git for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working severity/high low < medium < high < critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@JamWils @jpellizzari @J-Thompson12 @rokshana-b