Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text2vec-aws module doesn't support temporary credentials #4558

Open
1 task done
bbeaumatin opened this issue Mar 27, 2024 · 0 comments
Open
1 task done

text2vec-aws module doesn't support temporary credentials #4558

bbeaumatin opened this issue Mar 27, 2024 · 0 comments

Comments

@bbeaumatin
Copy link

Describe your feature request

Problem:
At the moment the module can only take permanent credentials "access key" and "secret key".

Solution:
A common way of consuming AWS APIs also involves temporary credentials : https://docs.aws.amazon.com/IAM/latest/UserGuide/security-creds.html#sec-access-keys-and-secret-access-keys

Basically it would need to receive a "session token" additionally to the access key and secret key, in order to be able to pass those temp credentials.

Also those credentials can expire, so it means the module could either use the go SDK of aws to ensure the logic of the credentials provider is the same as usual other uses of AWS sdks (there is a logical chain of keys providers), or otherwise document that the app instantiating the aws client takes the responsibility of recreating the client upon expiration of the keys (which might not be straightforward in some scenarios)

Let me know if it needs more meaningful information.

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant