Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src ignored in Bower distribution leads to problems as it is referenced in web-animations-next.min.js.map #42

Open
samuelsvensson opened this issue Sep 22, 2015 · 4 comments

Comments

@samuelsvensson
Copy link

Hi,

I'm trying to use use the Bower package for an Ember project (building with Broccoli). Since the src folder is ignored by bower problems occure when building as there is a refernce in the *.js.map files to the src-folder.
The only way I can build successfully is to dissable sourcemaps, which makes me sad.

The same kind issue has been raised in the showdownjs/showdown project: showdownjs/showdown#200

Thoughts?

Best regards,
Samuel

@dstoc
Copy link
Contributor

dstoc commented Oct 9, 2015

I'm not sure what we can do about this, we were forced to remove the src directory from bower to avoid issues with other build systems packing all the files.

@eguitarz
Copy link

@dstockwell Can you provide non-minified version in bower distribution? That way we don't have to refer to source map. Otherwise we can't use this amazing library in ember project at all...

@eguitarz
Copy link

eguitarz commented Jan 5, 2016

Actually, we don't need sourceMap for non-development usage. May I ask why we need source map here? I don't see any famous JS project (jQuery, moment.js ...) released source map in product.

@BrianSipple
Copy link

BrianSipple commented Nov 6, 2016

For anyone else in the Ember community who's coming to this issue, I created an addon that does some manual heavy-lifting to get around this -- that is, it copies the contents of src to the web-animations-js directory within a consuming app's Bower directory (after bower installing web-animations-js itself into the consuming application).

Of course, I'd be very interested in any updates here that would render this unnecessary, but it's getting the job done at the moment.

(cc @eguitarz, @samuelsvensson)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants