Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rspack v0.4.1 minify generates invalid token #4906

Closed
chenjiahan opened this issue Dec 5, 2023 · 1 comment
Closed

Rspack v0.4.1 minify generates invalid token #4906

chenjiahan opened this issue Dec 5, 2023 · 1 comment
Assignees
@bvanjoi
Labels
bug Something isn't working pending triage The issue/PR is currently untouched. rsbuild rsbuild related team The issue/pr is created by the member of Rspack.

Comments

@chenjiahan
Copy link
Member

System Info

System:
OS: macOS 13.5.2
CPU: (10) arm64 Apple M1 Pro
Memory: 2.32 GB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Yarn: 1.22.19 - ~/Library/Application Support/fnm/node-versions/v18.14.1/installation/bin/yarn
npm: 9.3.1 - ~/Library/Application Support/fnm/node-versions/v18.14.1/installation/bin/npm
pnpm: 7.18.1 - ~/Library/Application Support/fnm/node-versions/v18.14.1/installation/bin/pnpm
Browsers:
Chrome: 119.0.6045.199
Safari: 16.6

Details

Rspack v0.4.1 minify generates invalid token and breaks Rspress SSG.

image

image

Reproduce link

https://github.com/chenjiahan/rspack-repro-rspress-ssg-fail

Reproduce Steps

  1. pnpm i
  2. pnpm build
@chenjiahan chenjiahan added bug Something isn't working pending triage The issue/PR is currently untouched. rsbuild rsbuild related labels Dec 5, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 5, 2023
@chenjiahan chenjiahan mentioned this issue Dec 5, 2023
Merged
3 tasks
@bvanjoi
Copy link
Collaborator

bvanjoi commented Dec 6, 2023

I think this issue had been fixed.

Related to:

And I believe rspack@0.4.2 should work just fine.

@bvanjoi bvanjoi closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bvanjoi bvanjoi

Labels
bug Something isn't working pending triage The issue/PR is currently untouched. rsbuild rsbuild related team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chenjiahan @bvanjoi