Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support lastUpdatedAuthor #725

Open
colinaaa opened this issue Mar 6, 2024 · 6 comments
Open

[Feature]: Support lastUpdatedAuthor #725

colinaaa opened this issue Mar 6, 2024 · 6 comments
Assignees

Comments

@colinaaa
Copy link

colinaaa commented Mar 6, 2024

What problem does this feature solve?

It is nice that rspress supports lastUpdated! But popular tools like docusaurus supports things like: showLastUpdateAuthor which shows not only the updated time but also the author.

E.g.:
image

It would be nice if rspress could support this. It would be even better if the displayed content could be customized(we use pnpm patch tricks in docusaurus to display the user.email of the author instead of the default user.name).

What does the proposed API look like?

  • Enabled by lastUpdated: true.
  • New config: lastUpdatedAuthor:
    • Set to false to disable displaying author.
    • Set to (path: string) => string to modify the display text.
@sanyuan0704
Copy link
Collaborator

That's right, a nice feature!

@wChenonly
Copy link
Contributor

wChenonly commented Mar 7, 2024

That's right, a nice feature!

Can you assign it to me to try?

@sanyuan0704
Copy link
Collaborator

That's right, a nice feature!

Can you assign it to me to try?

Sure

@wChenonly wChenonly removed their assignment Mar 7, 2024
@wChenonly
Copy link
Contributor

@wChenonly wChenonly removed their assignment Mar 7, 2024
sorry,The wrong point 🤣

@sanyuan0704
Copy link
Collaborator

@wChenonly Let me assign you again

@sanyuan0704
Copy link
Collaborator

Welcome you PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants