New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Change Proposal for font-size-adjust
#634
Comments
There are also subtests for ic-height in: css-fonts/parsing/font-size-adjust-computed.html |
Updated issue description with those. |
@jgraham / @zcorpan can you review for Gecko? |
Given it's early in the year I slightly favor the option of standardizing |
Yes, alternatively can we move the ic-height stuff to separate tests, or guard it with |
Moving |
Following w3c/csswg-drafts#6384 I can foresee two possible outcomes:
Do these outcomes sound reasonable to everyone on this thread? And would folks agree on checking tests and if needed or non interopable: removing expectations for fallback behavior from tests in the case of 1)? This also means, we're okay shipping ic-height if in WPT tests we don't try to attempt to test or pretend we have interoperable fallback behavior in absence of the metric. |
Test List (updated)
css-fonts/animations/font-size-adjust-composition.html
- remove any tests that refer toic-height
.css-fonts/parsing/
- ditto, remove any tests that refer toic-height
.font-size-adjust-computed.html
font-size-adjust-valid.html
font-size-adjust-invalid.html
Rationale
ic-height
fallback behavior is unresolved, compare w3c/csswg-drafts#6384As long as we do not have a consistent, testable specified behavior for what we do when
ic-height
is not available, we can not logically achieve meaningful interop, or complete test coverage. There are realistic scenarios where the value is not available, and UA specific fallbacks cause the kind of surprising behavior that we want to remove through the Interop effort.CC @shivamidow @lilles
The text was updated successfully, but these errors were encountered: