Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize META.yml indentation #2209

Open
foolip opened this issue Nov 24, 2021 · 3 comments
Open

Normalize META.yml indentation #2209

foolip opened this issue Nov 24, 2021 · 3 comments

Comments

@foolip
Copy link
Member

foolip commented Nov 24, 2021

When working on #2196 I noticed different indentation in different files, which made it harder to work with the files.

Could we normalize the formatting of META.yml files and enforce that formatting in the lint?

@KyleJu WDYT?

P.S. I thought there was already an issue about this but I couldn't find it. Sorry if it is nevertheless a dupe of some existing issue.

@KyleJu
Copy link
Contributor

KyleJu commented Nov 24, 2021

Yea I think there was issue where PRs create huge diff after the indentation changes. #2207 all the gecko updates have less indentation than the default one. Let me find a way to enforce the format in the lint

@foolip
Copy link
Member Author

foolip commented Nov 25, 2021

Oh, does the Gecko sync bot not use the API for updating metadata then?

@KyleJu
Copy link
Contributor

KyleJu commented Nov 25, 2021

Oh, does the Gecko sync bot not use the API for updating metadata then?

nope I think they use a separate script. I am unsure what YAML library they use, which leads to a difference in formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants