Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assign the owner of a PR #78

Open
foolip opened this issue Aug 27, 2019 · 3 comments
Open

Don't assign the owner of a PR #78

foolip opened this issue Aug 27, 2019 · 3 comments

Comments

@foolip
Copy link
Member

foolip commented Aug 27, 2019

On web-platform-tests/wpt#18677 @wpt-pr-bot assigned me even though I sent the PR. That's not very helpful.

@foolip
Copy link
Member Author

foolip commented Aug 27, 2019

It looks like this shouldn't happen:

var reviewers = metadata.reviewersExcludingAuthor;

So the question then becomes why it did. The PR was initially a draft, might that explain it?

@jugglinmike
Copy link
Contributor

That pull request was reviewed by its author, and as per gh-55, the script assigns the latest reviewer.

That review came hours after the pull request was opened, though. So the new question is: why didn't the bot assign a reviewer initially?

It's not that the pull request was a draft since (per gh-69) we know the script responds to such events.

@foolip
Copy link
Member Author

foolip commented Aug 27, 2019

Oh, I was just "reviewing" to get inline comments grouped together in a batch, I didn't even consider that activity as a review. But that explains what happened here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants