Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog styling does not respect theme roundness value #386

Open
Absor opened this issue May 13, 2024 · 3 comments
Open

Dialog styling does not respect theme roundness value #386

Absor opened this issue May 13, 2024 · 3 comments
Labels
bug Something isn't working needs more info Needs more information needs repro Needs reproducible example

Comments

@Absor
Copy link

Absor commented May 13, 2024

Current behaviour

Dialog has rounded corners even if you specify roundness: 0 in paper theme.

Expected behaviour

Dialog to not have rounded corners when roundness is set to zero.

How to reproduce?

Create a theme with roundness set to zero and provide that to PaperProvider. Use time picker inside the provider and see that the corners are rounded.

Preview

What have you tried so far?

This is just wrong in current implementation. Roundness is not even considered.

Your Environment

software version
ios x
android x
react-native x.x.x
react-native-paper x.x.x
node x.x.x
npm or yarn x.x.x
expo sdk x.x.x
@Absor Absor added the bug Something isn't working label May 13, 2024
@iM-GeeKy iM-GeeKy added needs repro Needs reproducible example needs more info Needs more information labels May 13, 2024
Copy link
Contributor

Hey! Thanks for opening the issue. Can you provide a minimal repro which demonstrates the issue? Posting a snippet of your code in the issue is useful, but it's not usually straightforward to run. A repro will help us debug the issue faster. Please try to keep the repro as small as possible. The easiest way to provide a repro is on snack.expo.dev. If it's not possible to repro it on snack.expo.dev, then you can also provide the repro in a GitHub repository.

@iM-GeeKy
Copy link
Collaborator

PRs are welcome!

Copy link
Contributor

Hey! Thanks for opening the issue. Can you provide more information about the issue? Please fill the issue template when opening the issue without deleting any section. We need all the information we can, to be able to help. Make sure to at least provide - Current behaviour, Expected behaviour, A way to reproduce the issue with minimal code (link to snack.expo.dev) or a repo on GitHub, and the information about your environment (such as the platform of the device, versions of all the packages etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info Needs more information needs repro Needs reproducible example
Projects
None yet
Development

No branches or pull requests

2 participants