Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"The track is not recognized" notification very trigger-happy #4719

Open
Mojken opened this issue May 18, 2024 · 0 comments
Open

"The track is not recognized" notification very trigger-happy #4719

Mojken opened this issue May 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Mojken
Copy link

Mojken commented May 18, 2024

Describe the bug
The notification for unknown tracks appears for every single song, even though the track gets recognized a second or two afterwards. Only tested on Youtube Music.

How to reproduce
Steps to reproduce the behavior:

  1. Play any song
  2. See notification
  3. Notice how the song actually is recognized, at least now

Expected behavior
The notification should only appear after the plugin has had the chance to detect a song, maybe just put it on a 10-ish second timer?

Debug logs
All three omitted sections are responses from last.fm for the correct song

changed mode to Loading in tab 2 2 main.js:7:18686  
Web Scrobbler: Send "get info" request: 1 main.js:1:12534  
Web Scrobbler: Send "get info" request: 1 main.js:1:12534  
Last.fm: track.getinfo response:  
{  
[OMITTED]  
} main.js:1:10236  
changed mode to Unknown in tab 2 main.js:7:18686  
song changed in tab 2 main.js:7:18837  
Object { parsed: {…}, noRegex: {…}, processed: {…}, metadata: {…}, flags: {…}, connector: {…} }  
main.js:7:18903  
Last.fm: track.getinfo response:  
{  
[OMITTED]  
} main.js:1:10236  
song changed in tab 2 main.js:7:18837  
Object { parsed: {…}, noRegex: {…}, processed: {…}, metadata: {…}, flags: {…}, connector: {…} }  
main.js:7:18903  
Web Scrobbler: Send "now playing" request: 1 main.js:1:12534  
Last.fm: track.updatenowplaying response:  
{  
[OMITTED]  
} main.js:1:10236  
changed mode to Playing in tab 2 main.js:7:18686

Environment (please complete the following information)

  • OS: Linux
  • Browser: Firefox
  • Extension version: v3.7.0
@Mojken Mojken added the bug Something isn't working label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant