Do not deprecate the support for PSR-18 HTTP clients

[Cyperghost]

Description

jwt-framework/src/Library/KeyManagement/UrlKeySetFactory.php

Lines 22 to 31 in 1dbef13

	if ($this->client instanceof ClientInterface) {
	trigger_deprecation(
	'web-token/jwt-library',
	'3.3',
	'Using "%s" with an instance of "%s" is deprecated, use "%s" instead.',
	self::class,
	ClientInterface::class,
	HttpClientInterface::class
	);
	}

In our application we use Guzzle and not any feature of Symfony. Is there any point that you can support PSR-18 HTTP clients too?

It would be good to have the same solutions as web-auth/webauthn-framework#482
Another solution would be to move UrlKeySetFactory to the bundle.

Example

No response

[Spomky]

Hi,

Actually, the JKUFactory and the X5UFactory can be easily extended to be used with any HTTP Client.
In version 4.0, symfony/http-client will be mandatory only if you use the classes, but you are free to implement your own class.

namespace Acme;

use GuzzleHttp\Client;
use Jose\Component\KeyManagement\JKUFactory;

final class GuzzleJKUFactory extends JKUFactory
 {
    pulbic function __construct(private readonly Client $client) {}

    /**
     * @param array<string, string|string[]> $header
     */
    protected function getContent(string $url, array $header = []): string
    {
        //Place Guzzle calls here
        $this->client->request(...
    }
}