Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken test.js that stops the deployment of Github Pages of updates #2

Closed
niclaz opened this issue May 17, 2024 · 3 comments
Closed

Comments

@niclaz
Copy link
Contributor

niclaz commented May 17, 2024

Just submitted a PR to edit an event within /data/src/events... then I noticed that there were tests failing in previous edits of codebase

See: https://github.com/web3privacy/data/actions/workflows/deploy.yml

It seems that the test broke 2 months ago: https://github.com/web3privacy/data/actions/runs/8459840597

The previous commit did not change the code of the tests...

Something broke in the deploy script...

here are the errors thrown by the Github Deployer:

"Process completed with exit code 2.

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: szenius/set-timezone@v1.0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: szenius/set-timezone@v1.0. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/"

Researching and attempting a fix in my own fork of repo

@niclaz
Copy link
Contributor Author

niclaz commented May 17, 2024

Attempting to fix by changing deploy.yaml in /data/.github/workflows directory

'szenius/set-timezone@v1.0' was flagged by error thrown

The package has been updated to v2.0: https://github.com/szenius/set-timezone

PR Created: #3

@burningtree
Copy link
Contributor

Problem was invalid YAML files (or people definition):

Now it should be fixed and build work normally. Thanks for investigation!

@niclaz
Copy link
Contributor Author

niclaz commented May 21, 2024

excellent, thanks for the links to the yamls. it lets me understand the file-structure a little bit better

@niclaz niclaz closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants