Invalid manifest with the latest mini-css-extract-plugin

[renchap]

After updating mini-css-extract-plugin from 0.4.2 to 0.4.3, the manifest is no longer valid.
Assets referenced via the CSS are missing, and some assets are pointing to unrelated paths. For example (from the issue below):

With 0.4.2:
"images/create/wallet.png": "images/create/wallet.png"

With 0.4.3
"images/create/Create.scss": "images/create/wallet.png"

See webpack-contrib/mini-css-extract-plugin#177 (comment)

According to @evilebottnawi this is a problem with the manifest plugin, not the referenced change.

[webdeveric]

@renchap I'm using module.userRequest to get the original filename and it is wrong when using mini-css-extract-plugin 0.4.3. Its fine in 0.4.2 and below. Its being set to the css file instead of the asset (bg image, font, etc.). The other loaders I'm using have the expected value for module.userRequest.

I tried another webpack manifest plugin and I get the same result. This issue is not isolated to my plugin.

[piecyk]

@webdeveric had a quick look, maybe this approach is better? It looks like it fixes the issue also all your test pass 🤔 IMHO using module.identifier() is much safer, what do you think ?

piecyk@2e07ad9

[piecyk]

Hmm maybe even simpler, only set name and originalName when extensions match

piecyk@5dcba5c

[webdeveric]

@piecyk I'm trying it out locally. It looks promising.

[webdeveric]

@renchap I have a fix in my dev branch.

Can you try it out and let me know how it works for you?

npm install https://github.com/webdeveric/webpack-assets-manifest.git#dev

[renchap]

Seems to work fine for me! 👍

[webdeveric]

@renchap The updated version has been published to npm.

[piecyk]

Good work @webdeveric 👍