Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CICD: add extended tests to GitHub Actions (or npm test script) to verify browser compatibility #152

Open
tehhowch opened this issue Oct 25, 2021 · 5 comments

Comments

@tehhowch
Copy link
Contributor

The current CICD steps and npm test script only use Google Chrome for testing, but this package purports to have extreme backwards compatibility. The CICD process should reflect that, to help contributors verify that their code will work, even on browsers that may not be available for them to use.

Specifically, there should be an IE 11 GitHub Action that is used to execute the same tests that are run by npm test, if IE 11 is to be a supported browser.

@christian-bromann
Copy link
Contributor

@tehhowch more tests are always good! You want to take a stab at this? I am happy to provide you with an Open Sauce account.

@tehhowch
Copy link
Contributor Author

Adding actions that require third party accounts securely is not something I or any non-administrator can do, so I don't know what providing such an account would be useful for.

Probably the simplest thing that could be added is an ESLint config that enforces a maximum language level of ES3 in the interceptor file, along with a GitHub action that runs e.g. npx eslint.

@christian-bromann
Copy link
Contributor

so I don't know what providing such an account would be useful for.

I could be useful to run tests in an actual IE11. GitHub is offering ways to use such accounts in a secure way, e.g. it doesn't run these tests for PRs only once you accept it to run.

@tehhowch
Copy link
Contributor Author

so I don't know what providing such an account would be useful for.

I could be useful to run tests in an actual IE11. GitHub is offering ways to use such accounts in a secure way, e.g. it doesn't run these tests for PRs only once you accept it to run.

Sure; my point is that it doesn't make sense to give me such an account. This repo is not mine; I am not able to add secrets to it, nor should I add my secrets to it--one would want a general service account that needs no credentials. Then such a CI action can be somewhat helpful (run on every PR that gets opened here) or perhaps majorly helpful (run upon pushes to any branch of any fork of this repo).

@christian-bromann
Copy link
Contributor

You right, I am just proposing that if someone decides to pick Sauce Labs as vendor, I could create an OSS account and set it up here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants