Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression of https://github.com/webdriverio/webdriverio/pull/6487 #6716

Closed
pmerwin opened this issue Apr 14, 2021 · 3 comments
Closed

Regression of https://github.com/webdriverio/webdriverio/pull/6487 #6716

pmerwin opened this issue Apr 14, 2021 · 3 comments

Comments

@pmerwin
Copy link
Contributor

pmerwin commented Apr 14, 2021

Seeing this issue again with vs 7.4, devtools backend shrinks viewsport, chrome-driver works. Using latest chrome : Version 89.0.4389.128 (Official Build) (x86_64)

#6487
@L0tso
Copy link
Contributor

L0tso commented Apr 14, 2021

@christian-bromann Fix was removed here. Was it necessary?

@christian-bromann
Copy link
Member

I removed it because of this comment:

// @ts-ignore ToDo(@L0tso): remove once puppeteer/puppeteer#6942 is merged

but now I realise that the comment was about remove the comment not the viewport property.

@christian-bromann
Copy link
Member

Fixed and released with v7.4.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@christian-bromann @L0tso @pmerwin