Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Migrate 'latest-version' version to 7.0.0 and fit it with ESM. #5468

Closed
wants to merge 1 commit into from
Closed

Fix: Migrate 'latest-version' version to 7.0.0 and fit it with ESM. #5468

wants to merge 1 commit into from

Conversation

bennytaccardi
Copy link

Migrating 'latest-version' from 5.1.0 to 7.0.0. New version uses ESM instead of CommonJS. A new script has been added to allow 'latest-version' to be updated.

Fix: #5464

Pull request checklist

Make sure you:

For non-trivial changes, please make sure you also:

  • Added/Updated related documentation.
  • Added/Updated related tests.

Short description of the change(s)

This pull request updates the 'latest-version' version from 5.1.0 to 7.0.0 in the package.json file. The new version does not support CommonJS, but it supports ESM. As a result, the 'build:scripts:ts' line was also modified to include a script that adapts CommonJS to ESM. This modification has been done in order to not adapt all project files to EMS standard.
The new script, 'adapt-cjs-to-esm.js', reads the file content from 'dist/release/tasks/get-packages.js', replaces the statement with a new one, and writes the updated content back to the file.
Overall, this pull request ensures that the project is updated to use the latest version of 'latest-version' and is compatible with ESM.

Migrating 'latest-version' from 5.1.0 to 7.0.0. New version uses ESM instead of CommonJS. A new script has been added to allow 'latest-version' to be updated.

Ref: #5464
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@bennytaccardi bennytaccardi deleted the fix-5464 branch March 26, 2023 09:56
@bennytaccardi bennytaccardi restored the fix-5464 branch March 26, 2023 10:00
@bennytaccardi bennytaccardi deleted the fix-5464 branch March 26, 2023 10:53
@bennytaccardi bennytaccardi restored the fix-5464 branch March 26, 2023 10:55
@bennytaccardi bennytaccardi deleted the fix-5464 branch March 26, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Upgrade 'latest-version' to version 7
1 participant