Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amphp/amp v3 compatibility #1474

Open
abdullahseba opened this issue Oct 30, 2023 · 5 comments
Open

amphp/amp v3 compatibility #1474

abdullahseba opened this issue Oct 30, 2023 · 5 comments
Labels
enhancement

Comments

@abdullahseba
Copy link
Contributor

The bundled AMP PHP adaptor is not compatible with APM V3 and causes an error when used. Amp server is listed as a dev dependency so maybe it should be version-locked until this is fixed?
@spawnia
Copy link
Collaborator

spawnia commented Nov 28, 2023

What is APM V3?

@abdullahseba
Copy link
Contributor Author

Sorry, AMP v3*

@spawnia spawnia changed the title AMP PHP Adaptor Not Compatible with APM V3 amphp/amp v3 compatibility Nov 29, 2023
@spawnia
Copy link
Collaborator

spawnia commented Nov 29, 2023

See #1262 (comment).

@abdullahseba
Copy link
Contributor Author

If it's not being done now, the version should be locked to 2.x in composer.json?

@spawnia
Copy link
Collaborator

spawnia commented Dec 17, 2023

No, as it is an optional dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spawnia @abdullahseba