error with sourcemaps #68

dancespiele · 2017-11-09T19:20:50Z

I reproduce this issue when I use source maps with this plugin.
My config file:

const path = require('path')
const webpack = require("webpack");
const HtmlWebpackPlugin = require('html-webpack-plugin');
const MinifyPlugin = require("babel-minify-webpack-plugin");

module.exports = {
	entry: path.resolve(__dirname, './app/component/index'),
    devtool: 'source-map',
	output: {
		path: path.resolve(__dirname, './dist'),
		filename: 'app.bundle.js'
	},

	resolve: {
		extensions: ['.ts', '.tsx', '.js', '.jsx']
	},

	module: {
		rules: [{
			test: /\.tsx?$/,
			exclude: /node_modules/,
			loaders: ['ts-loader']
		}, {
			test: /\.css$/,
			include: /node_modules/,
			loaders: ['style-loader', 'css-loader']
		}, {
			test: /\.scss$/,
			use: [{
				loader: "style-loader"
			}, {
				loader: "css-loader"
			}, {
				loader: "sass-loader"
			}]
		}, {
			test: /\.(eot|svg|ttf|woff|woff2)$/,
			loaders: ['file-loader?name=fonts/[name].[ext]']
        }]
    },
    
    plugins: [
        new MinifyPlugin()
    ]
}

The error which I get is this:

/home/razorpack/develop/pyrite-prism/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:276
        throw new Error(
        ^

Error: original.line and original.column are not numbers -- you probably meant to omit the original mapping entirely and only map the generated position. If so, pass null for the original mapping instead of an object with empty or null values.
    at SourceMapGenerator_validateMapping [as _validateMapping] (/home/razorpack/develop/pyrite-prism/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:276:15)
    at SourceMapGenerator_addMapping [as addMapping] (/home/razorpack/develop/pyrite-prism/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:110:12)
    at /home/razorpack/develop/pyrite-prism/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:72:17
    at Array.forEach (<anonymous>)
    at BasicSourceMapConsumer.SourceMapConsumer_eachMapping [as eachMapping] (/home/razorpack/develop/pyrite-prism/node_modules/webpack-sources/node_modules/source-map/lib/source-map-consumer.js:157:14)
    at Function.SourceMapGenerator_fromSourceMap [as fromSourceMap] (/home/razorpack/develop/pyrite-prism/node_modules/webpack-sources/node_modules/source-map/lib/source-map-generator.js:48:24)
    at SourceMapSource.node (/home/razorpack/develop/pyrite-prism/node_modules/webpack-sources/lib/SourceMapSource.js:32:35)
    at SourceMapSource.proto.sourceAndMap (/home/razorpack/develop/pyrite-prism/node_modules/webpack-sources/lib/SourceAndMapMixin.js:30:18)
    at getTaskForFile (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/SourceMapDevToolPlugin.js:33:30)
    at chunk.files.forEach.file (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/SourceMapDevToolPlugin.js:91:21)
    at Array.forEach (<anonymous>)
    at /home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/SourceMapDevToolPlugin.js:89:18
    at Array.forEach (<anonymous>)
    at Compilation.<anonymous> (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/SourceMapDevToolPlugin.js:88:12)
    at Compilation.applyPlugins1 (/home/razorpack/develop/pyrite-prism/node_modules/tapable/lib/Tapable.js:75:14)
    at self.applyPluginsAsync.err (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/Compilation.js:670:11)
    at next (/home/razorpack/develop/pyrite-prism/node_modules/tapable/lib/Tapable.js:202:11)
    at Compilation.<anonymous> (/home/razorpack/develop/pyrite-prism/node_modules/babel-minify-webpack-plugin/dist/index.js:119:11)
    at Compilation.applyPluginsAsyncSeries (/home/razorpack/develop/pyrite-prism/node_modules/tapable/lib/Tapable.js:206:13)
    at self.applyPluginsAsync.err (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/Compilation.js:666:10)
    at Compilation.applyPluginsAsyncSeries (/home/razorpack/develop/pyrite-prism/node_modules/tapable/lib/Tapable.js:195:46)
    at sealPart2 (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/Compilation.js:662:9)
    at Compilation.applyPluginsAsyncSeries (/home/razorpack/develop/pyrite-prism/node_modules/tapable/lib/Tapable.js:195:46)
    at Compilation.seal (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/Compilation.js:605:8)
    at applyPluginsParallel.err (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/Compiler.js:508:17)
    at /home/razorpack/develop/pyrite-prism/node_modules/tapable/lib/Tapable.js:289:11
    at _addModuleChain (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/Compilation.js:507:11)
    at processModuleDependencies.err (/home/razorpack/develop/pyrite-prism/node_modules/webpack/lib/Compilation.js:477:14)
    at _combinedTickCallback (internal/process/next_tick.js:131:7)
    at process._tickCallback (internal/process/next_tick.js:180:9)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! pyrite-bootstrap@0.0.1 production: `webpack --config ./webpack.production.config.js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the pyrite-bootstrap@0.0.1 production script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/razorpack/.npm/_logs/2017-11-09T19_15_16_251Z-debug.log

When I use the source maps without this plugin it works fine.
The version plugin is: 0.2.0

The text was updated successfully, but these errors were encountered:

michael-ciniawsky · 2017-11-10T00:33:51Z

Could you try to provide a small repo with a file/module where this error occurs ? I'm currently debugging this and a failing example would be quite helpful :)

dancespiele · 2017-11-10T09:12:47Z

Sure @michael-ciniawsky, this is the repository https://github.com/pyrite-components/pyrite-prism . You have to install as global nodemon and typescript. To reproduce the fail you need to execute npm run production

simonbuchan · 2017-11-15T02:03:49Z

In particular, I found cheap-* source maps work, e.g. module-source-map dies, while cheap-module-source-map does not.

webpack-contrib/babel-minify-webpack-plugin#68

ingro · 2017-12-04T13:32:54Z

Got the same problem, using cheap-source-map instead of source-map doesn't throw error though.

timwis · 2017-12-05T11:32:02Z

Just want to chime in that this is happening to me too. Ref webpack/webpack#5931

For those unfamiliar with cheap-source-map, here's some docs: https://webpack.js.org/configuration/devtool/

eliperelman · 2017-12-08T18:53:38Z

Running git bisect on this turns up the following commit:

❯ git bisect good
d0a724cec766ea5fbea9ecc514d38f7fd2ee3735 is the first bad commit
commit d0a724cec766ea5fbea9ecc514d38f7fd2ee3735
Author: Joshua Wiens <wiens.joshua@gmail.com>
Date:   Sat Aug 12 02:50:01 2017 -0500

    refactor: Apply webpack-defaults (#51)

    * refactor: Init webpack-defaults
    * style: Update for defaults
    * chore: Remove legacy babel env setting
    * chore: Update repo & bugs in pacakge.json
    * test: Fix source map test assertion syntax

    BREAKING CHANGE: Enforces `engines` of `"node": ">=4.3.0 < 5.0.0 || >= 5.10`
    BREAKING CHANGE: Enforces `peerDependency` of `"webpack": "^2.0.0 || ^3.0.0`

:100644 100644 354caa95dfed982fff17dafbe378e1b253fdbdba e7e4dbd99b91e6c699aeecd4e21b72594c00093e M	.babelrc
:100644 100644 1a096400cea55f9c0bfd7abb3da880c31ffce53d 1f899991b1335c3b8fc09a137fa5e6269bb2b65e M	.editorconfig
:000000 100644 0000000000000000000000000000000000000000 b2d59d1f7578b05e96f3b3f8a7d5039df3d06fb6 A	.eslintignore
:000000 100644 0000000000000000000000000000000000000000 4016c3eed18c749c8d968ccf89ce374bbb611842 A	.eslintrc
:100644 000000 d98f68986934414fd629c5a9774bcb810a4bf237 0000000000000000000000000000000000000000 D	.eslintrc.js
:000000 100644 0000000000000000000000000000000000000000 b07091b9b12ca11a84f562f56cdb4156712280be A	.gitattributes
:000000 040000 0000000000000000000000000000000000000000 7094ba2f4446b63099d07d17b7663d5412d01a74 A	.github
:100644 100644 8a05de541c440248984dc2b58407e2a327875b31 de347064f4986dab4d1133dc79dde317f7d48c7b M	.gitignore
:100644 100644 ddccd23750a34fbd08773ef6a2d7615c6137835c 76b149227e1523aaecc5a129652073d922571d6d M	.travis.yml
:000000 100644 0000000000000000000000000000000000000000 95fd7360e907a3797f16dcef7b00d4b138d4ca06 A	CHANGELOG.md
:000000 100644 0000000000000000000000000000000000000000 aa4f18a5043eac562724cbfd7f2ec1f5b7764b77 A	appveyor.yml
:000000 100644 0000000000000000000000000000000000000000 0dde8ba5af5e47cfa7fdf40e444f986ac3d6db2c A	package-lock.json
:100644 100644 cce2507527c11f4a2e0f1e4e44d1035dae31da0c 9bb3ec1bb62095452e50c3e4379092b566a6fa4b M	package.json
:040000 040000 908bc17c9eaea633e6821e219a4ca213d945cdd4 e3c1dacbbd18feab5b4451ac516841134d14d79f M	src
:040000 040000 5dc5817b66f78e6ea66ccd3e51410b03f1e1753e 82c3316b8e07d066761dd89486d54ba1ef656838 M	test
:100644 000000 b36b79094e0678df41773b4ed923b7c561459e44 0000000000000000000000000000000000000000 D	yarn.lock

bradchoate · 2017-12-12T18:13:37Z

Also having this problem with the 'source-map' option.

nealoke · 2017-12-16T16:15:06Z

Just wanted to chip in and say that in my case it doesn't matter if i use the BabiliPlugin() or not, as long as I don't have the "webpack-sources": "1.0.1" installed it always fails.

Also wanted to provide you with my files used:

Cases

npm run server -> no error
npm run server:test -> error (if webpack-sources@1.0.1 is not explicitly installed)
npm run build:prod -> no error

Alfredo-Delgado · 2017-12-18T16:24:01Z

I'm running into the same problem. I worked around it by pinning babili-webpack-plugin to 0.1.1.

cf. webpack/webpack#5931 (comment)

saiichihashimoto · 2018-01-04T05:19:44Z

So what's going on here? It seems like a breaking commit has been identified and that, most of the time, cheap-* avoids the problem while others don't. Do we need more repro examples?

simonbuchan · 2018-01-04T06:20:20Z

I'd guess cheap-* "fixing" it is since IIRC that disables minification source mapping (not much point mapping line-by-line if you only output one line!), but that doesn't narrow it down much. Seems there are plenty of references to this, so probably plenty of repro cases, just needs someone to spend the time on it.

arbaaz · 2018-01-04T07:55:19Z

I'm also facing this issue.

alexander-akait · 2018-02-02T11:08:28Z

Problem still exists? If yes please create minimum reproducible test repo. Thanks!

arbaaz · 2018-02-02T11:17:06Z

I commented out BabiliPlugin and it was working.

// new BabiliPlugin()

alexander-akait · 2018-02-02T11:20:38Z

@arbaaz Incredible solution

tarjei · 2018-02-02T11:40:55Z

I feel a bit bad about saying this, but I changed to Uglify-es and got very good results both wrt to compilation speed and sourcemaps.

alexander-akait · 2018-02-02T11:49:46Z

@tarjei i near future i implement cache and parallels, first we need fix bugs

tarjei · 2018-02-02T11:56:59Z

@evilebottnawi 👍

ghost · 2018-02-05T12:20:19Z

@evilebottnawi
I have the similiar problem, and here is demo.

It was required to work around a source map bug when using newer `webpack-sources` with `babel-minify-webpack-plugin`: webpack-contrib/babel-minify-webpack-plugin#68 However now that we're using `uglify-es` instead, we can stop pinning the `webpack-sources` version and pick up some of the bug/perf fixes: https://github.com/webpack/webpack-sources/releases

jbelien · 2018-09-06T12:16:09Z

Any fix / workaround available for this issue ?

Temporarily disabling sourcemaps with config.devtool = false until solution is found.

I did the same but it's a bit unfortunate ...

Disable source-map for production due to issue with Babel plugin. See webpack-contrib/babel-minify-webpack-plugin#68

Keep on hitting webpack-contrib/babel-minify-webpack-plugin#68.

…gin#68

Pushplaybang · 2018-11-01T22:51:01Z

@jbelien - use uglify. thats what I'm doing.

Fixes minification. webpack-contrib/babel-minify-webpack-plugin#68

from-the-river-to-the-sea · 2019-03-31T19:53:29Z

Hi there, I'm the person who added this error to source-map in mozilla/source-map#265. It looks like I didn't do a good enough job in explaining how to fix this error, I apologize for all the ruckus it has caused.

This error was added because, without it, source-map would silently output inaccurate mappings. I figured that a hard error was better than an inaccurate map.

Polymer/polymer-bundler#519 shows an example of how to fix this error in the code which calls source-map. For convenience, here's the relevant part of the diff:

It's basically just a bit of boilerplate which only adds the original object to the mapping if there is data to put in it. I'm not familiar enough with Babel or Webpack to say where exactly this fix needs to go, but hopefully somebody who knows more about webpack-sources can figure that part out.

I hope this helps, and sorry again for the trouble! If it's any consolation, this does at least indicate that potentially inaccurate source maps were being produced before, and this error is the first step to fixing them for everyone.

EDIT: I've filed mozilla/source-map#385 which I think is a potential root cause of this.

webpack-contrib/babel-minify-webpack-plugin#68

webpack-contrib/babel-minify-webpack-plugin#68 AfterShip#151

Workaround to AfterShip#151 Due to webpack-contrib/babel-minify-webpack-plugin#68

…-minify-webpack-plugin#68

source-map 관련 버전, 의존성 오류로 보임. webpack-contrib/babel-minify-webpack-plugin#68 gatsby에서 socurcemap을 비활성화하는 플러그인을 이용한 해결 gatsbyjs/gatsby#3817

A too large commit containing too many additions, most of which will be refactored. This commit lays the foundation for the calendar system, providing functionality to navigate months and highlighting dates. The additions can be summarized as follows: - Add component that keeps track of all calendar data and sub-components. Uses JavaScript's type. - Add module containing utility functions for interacting with JavaScript's type. - Add component that lays out a calendar month in a CSS grid. - Add file for localized theme settings. - Disable source maps in production due to Webpack errors. For similar issues, see webpack-contrib/babel-minify-webpack-plugin#68. - Other small things such as setting app-wide styles with , adding (Danish) names for months and weekdays, and adding scss support.

joysoft33 mentioned this issue Nov 17, 2017

When there's a broken sourcemap, error doesn't tell you which file it broke on webpack/webpack#5931

Closed

This was referenced Nov 22, 2017

Fix source-map option in production environment github/webpack-config-github#6

Closed

use cheal-source-map instead of source-map github/webpack-config-github#11

Merged

trazyn added a commit to trazyn/weweChat that referenced this issue Nov 24, 2017

fix #76, #75, #70

bef7ff8

webpack-contrib/babel-minify-webpack-plugin#68

trazyn mentioned this issue Nov 24, 2017

ubuntu16.04 node -v8.9.1 npm run package-linux错误 trazyn/weweChat#75

Closed

jamesisaac mentioned this issue Dec 5, 2017

UnhandledPromiseRejectionWarning when building #69

Closed

This was referenced Dec 8, 2017

Error generating source map with react-components preset neutrinojs/neutrino#578

Closed

Revert to earlier version of babel-minify-webpack-plugin due to sourcemap errors neutrinojs/neutrino#579

Merged

avesus mentioned this issue Dec 31, 2017

Improve the minification speed #71

Closed

alexander-akait added the flag: Needs more info label Feb 2, 2018

alexander-akait mentioned this issue Feb 5, 2018

breaks bundling #78

Closed

This was referenced Apr 30, 2018

Error: original.line and original.column are not numbers #82

Closed

Error: original.line and original.column are not numbers mozilla/source-map#304

Closed

source-map does not work with MinifyPlugin webpack/webpack#6131

Closed

wvankuipers mentioned this issue May 6, 2018

Update to source-map 0.6.1 causes an error when running Webpack webpack/webpack-sources#28

Closed

schmidtk mentioned this issue May 21, 2018

WIP: Upgrade to webpack 4 openlayers/openlayers#7740

Closed

4 tasks

jbelien added a commit to geo6/document-manager that referenced this issue Sep 6, 2018

Update webpack.config.js

3f88491

Disable source-map for production due to issue with Babel plugin. See webpack-contrib/babel-minify-webpack-plugin#68

RubenVerborgh added a commit to SolidOS/mashlib that referenced this issue Oct 17, 2018

Remove incompatible minifier.

cb5ba0d

Keep on hitting webpack-contrib/babel-minify-webpack-plugin#68.

kavsingh added a commit to kavsingh/gleetchy that referenced this issue Oct 18, 2018

temp disable prod sourcemaps webpack-contrib/babel-minify-webpack-plu…

5ecb88b

…gin#68

edmorley mentioned this issue Oct 19, 2018

Switch from uglifyjs-webpack-plugin (uglify-es) to terser-webpack-plugin (terser) webpack/webpack#7923

Closed

victorsh mentioned this issue Dec 5, 2018

Build Error - original.line & original.column networked-aframe/naf-firebase-adapter#2

Open

RubenVerborgh added a commit to linkeddata/rdflib.js that referenced this issue Mar 18, 2019

Pin webpack-sources to 1.0.1.

43d3f41

Fixes minification. webpack-contrib/babel-minify-webpack-plugin#68

RSSNorbertKeri mentioned this issue Mar 31, 2019

Norbertkeri/update hk phone AfterShip/phone#144

Merged

This was referenced Mar 31, 2019

chore(package): update deps obs-websocket-community-projects/obs-websocket-js#141

Open

SourceMapGenerator.fromSourceMap can error when using a source map which contains generated code mozilla/source-map#385

Open

corneliusweiss mentioned this issue May 2, 2019

Twing 2.2.0 not working in browser NightlyCommit/twing#314

Closed

ebaynaud added a commit to ebaynaud/phone that referenced this issue Jun 7, 2019

Disabling source-map

c2dd809

webpack-contrib/babel-minify-webpack-plugin#68

ebaynaud mentioned this issue Jun 7, 2019

Error with source-map while building AfterShip/phone#151

Closed

ebaynaud added a commit to ebaynaud/phone that referenced this issue Jun 7, 2019

Fix build error in prod due to source-map

dcbe2c6

webpack-contrib/babel-minify-webpack-plugin#68 AfterShip#151

ebaynaud added a commit to ebaynaud/phone that referenced this issue Jun 8, 2019

Disabling source-map

3dff3aa

Workaround to AfterShip#151 Due to webpack-contrib/babel-minify-webpack-plugin#68

ebaynaud added a commit to ebaynaud/phone that referenced this issue Jun 8, 2019

Disabling source-map

efcc101

Workaround to AfterShip#151 Due to webpack-contrib/babel-minify-webpack-plugin#68

ebaynaud added a commit to ebaynaud/phone that referenced this issue Jun 8, 2019

Disabling temporarily source-map

76e15da

Workaround to AfterShip#151 Due to webpack-contrib/babel-minify-webpack-plugin#68

ebaynaud mentioned this issue Jun 8, 2019

Disabling temporarily source-map AfterShip/phone#153

Closed

Bossa573 added a commit to AfterShip/phone that referenced this issue Jun 9, 2019

temporarily disable souce-map due to the bug of webpack-contrib/babel…

78258c1

…-minify-webpack-plugin#68

KyleAMathews mentioned this issue Jun 30, 2019

New installs of Gatsby fail on builds with source-map error gatsbyjs/gatsby#15249

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

error with sourcemaps #68

error with sourcemaps #68

dancespiele commented Nov 9, 2017 •

edited

michael-ciniawsky commented Nov 10, 2017

dancespiele commented Nov 10, 2017 •

edited

simonbuchan commented Nov 15, 2017

ingro commented Dec 4, 2017

timwis commented Dec 5, 2017 •

edited

eliperelman commented Dec 8, 2017

bradchoate commented Dec 12, 2017

nealoke commented Dec 16, 2017

Alfredo-Delgado commented Dec 18, 2017

saiichihashimoto commented Jan 4, 2018

simonbuchan commented Jan 4, 2018

arbaaz commented Jan 4, 2018

alexander-akait commented Feb 2, 2018 •

edited

arbaaz commented Feb 2, 2018

alexander-akait commented Feb 2, 2018

tarjei commented Feb 2, 2018

alexander-akait commented Feb 2, 2018

tarjei commented Feb 2, 2018

ghost commented Feb 5, 2018

jbelien commented Sep 6, 2018

Pushplaybang commented Nov 1, 2018

from-the-river-to-the-sea commented Mar 31, 2019 •

edited

error with sourcemaps #68

error with sourcemaps #68

Comments

dancespiele commented Nov 9, 2017 • edited

michael-ciniawsky commented Nov 10, 2017

dancespiele commented Nov 10, 2017 • edited

simonbuchan commented Nov 15, 2017

ingro commented Dec 4, 2017

timwis commented Dec 5, 2017 • edited

eliperelman commented Dec 8, 2017

bradchoate commented Dec 12, 2017

nealoke commented Dec 16, 2017

Alfredo-Delgado commented Dec 18, 2017

saiichihashimoto commented Jan 4, 2018

simonbuchan commented Jan 4, 2018

arbaaz commented Jan 4, 2018

alexander-akait commented Feb 2, 2018 • edited

arbaaz commented Feb 2, 2018

alexander-akait commented Feb 2, 2018

tarjei commented Feb 2, 2018

alexander-akait commented Feb 2, 2018

tarjei commented Feb 2, 2018

ghost commented Feb 5, 2018

jbelien commented Sep 6, 2018

Pushplaybang commented Nov 1, 2018

from-the-river-to-the-sea commented Mar 31, 2019 • edited

dancespiele commented Nov 9, 2017 •

edited

dancespiele commented Nov 10, 2017 •

edited

timwis commented Dec 5, 2017 •

edited

alexander-akait commented Feb 2, 2018 •

edited

from-the-river-to-the-sea commented Mar 31, 2019 •

edited