Skip to content
This repository has been archived by the owner on Oct 27, 2020. It is now read-only.

Generate normalized cache context relative paths #54

Conversation

mistic
Copy link
Collaborator

@mistic mistic commented Dec 21, 2018

This PR enables the cache context relative paths generation to always use normalized posix paths instead of specific OS ones.

\CC @evilebottnawi

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, let's add couple tests

@mistic
Copy link
Collaborator Author

mistic commented Dec 21, 2018

@evilebottnawi tests added

@mistic
Copy link
Collaborator Author

mistic commented Dec 31, 2018

@evilebottnawi can we merge this?

@alexander-akait
Copy link
Member

@mistic let's fix conflict and we can merge, also will be great fix CI before release new version

@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #54 into master will increase coverage by 0.35%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   58.11%   58.47%   +0.35%     
==========================================
  Files           2        2              
  Lines         117      118       +1     
  Branches       17       17              
==========================================
+ Hits           68       69       +1     
  Misses         42       42              
  Partials        7        7
Impacted Files Coverage Δ
src/index.js 58.97% <66.66%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148b2a0...a45f3af. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 4, 2019

Codecov Report

Merging #54 into master will increase coverage by 0.35%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   58.11%   58.47%   +0.35%     
==========================================
  Files           2        2              
  Lines         117      118       +1     
  Branches       17       17              
==========================================
+ Hits           68       69       +1     
  Misses         42       42              
  Partials        7        7
Impacted Files Coverage Δ
src/index.js 58.97% <66.66%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148b2a0...a45f3af. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants