Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feat validate options #419

Merged
merged 1 commit into from Dec 9, 2019
Merged

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

validate options

Breaking Changes

Should be no, of somebody will have problems feel free to open issue

Additional Info

No

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #419 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #419      +/-   ##
=========================================
- Coverage   94.89%   94.8%   -0.09%     
=========================================
  Files           9       9              
  Lines         294     289       -5     
  Branches       81      79       -2     
=========================================
- Hits          279     274       -5     
  Misses         14      14              
  Partials        1       1
Impacted Files Coverage Δ
src/preProcessPattern.js 97.56% <ø> (-0.12%) ⬇️
src/index.js 96.07% <100%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4826e56...5818af5. Read the comment docs.

@alexander-akait alexander-akait merged commit 452539a into master Dec 9, 2019
@alexander-akait alexander-akait deleted the feat-validate-options branch December 9, 2019 12:48
edmorley added a commit to neutrinojs/neutrino that referenced this pull request Dec 13, 2019
Since `copy-webpack-plugin` now validates the patterns passed, as of:
webpack-contrib/copy-webpack-plugin/pull/419
edmorley pushed a commit to neutrinojs/neutrino that referenced this pull request Dec 13, 2019
And:
* Update copy plugin test to pass valid options
   Since `copy-webpack-plugin` now validates the patterns passed, as of:
   webpack-contrib/copy-webpack-plugin/pull/419
* Bump in-range dependency versions
   Bumping the versions in theory shouldn't be necessary, however package
   managers tend to only update sub-dependencies lazily, so this ensures
   users are on the latest versions.

   Changes made using the approach described here:
   #1356 (comment)
@akx akx mentioned this pull request Mar 9, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant