Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icss option #1140

Merged
merged 1 commit into from Jul 29, 2020

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Jul 28, 2020

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

#1134 more broadly enabling other loaders to handle CSS Modules

src/index.js Outdated Show resolved Hide resolved
src/utils.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1140 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1140   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files          10       10           
  Lines         612      614    +2     
  Branches      188      189    +1     
=======================================
+ Hits          607      609    +2     
  Misses          5        5           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/utils.js 98.00% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc7b18d...8a11dd5. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexander-akait alexander-akait merged commit a8ec7da into webpack-contrib:master Jul 29, 2020
@jquense jquense deleted the add-icss-option branch July 29, 2020 14:01
@jquense
Copy link
Contributor Author

jquense commented Jul 29, 2020

thank you!

@alexander-akait
Copy link
Member

ETA is today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants