Match webpack sourcemap relative paths #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@evilebottnawi thanks for the tip |
|
Yep, easy to fix, update snapshot too |
isaacl
force-pushed
the
fixWebpackPaths
branch
3 times, most recently
from
c8e9859
to
2a41281
Compare
Adjust source path to match the way webpack generates sourcemaps for js. This makes css and js sources appear in the same directory when using sourcemaps in chrome. Fixes webpack-contrib#1218.
isaacl
force-pushed
the
fixWebpackPaths
branch
from
2a41281
to
00d2c29
Compare
|
Is it not loading my snapshot changes? |
|
Give me minute on fixing tests |
|
Let's merge as is and I will fix tests in other PR, want to fix it ASAP |
|
I'm really confused by why the tests are failing, it seems like linux is getting a different contenthash than on my mac |
|
but previously they were both getting the same hash |
|
hash is other because we change sources, so link on source maps changed also, so hash different, don't worry, all is fine |
isaacl
added a commit
to isaacl/css-loader
that referenced
this pull request
Nov 4, 2020
@evilebottnawi caused by merge conflict in webpack-contrib#1219
|
I tried in #1221 but it still fails idk |
This was referenced Mar 8, 2021
This was referenced Mar 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Adjust source path to match the way webpack generates sourcemaps
for js. This makes css and js sources appear in the same directory
when using sourcemaps in chrome.
Fixes #1218.
Breaking Changes
Additional Info