Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when using CSS modules' compose from a node_modules file #703

Closed
thibautRe opened this issue Apr 6, 2018 · 1 comment
Closed

Issue when using CSS modules' compose from a node_modules file #703

thibautRe opened this issue Apr 6, 2018 · 1 comment

Comments

@thibautRe
Copy link

thibautRe commented Apr 6, 2018

Do you want to request a feature or report a bug?
A bug

The bug was introduced by this PR.

What is the current behavior?
When trying to use compose from CSS modules from a node_modules dependency, it breaks with an Can't resolve error.

The bug has been introduced by this commit in css-loader but is actually only reproducible with postcss-loader as well (at least that's how I uncovered it)

If the current behavior is a bug, please provide the steps to reproduce.
Here's a reproduction of the bug. The idea is the following:

  • The application uses webpack, extract-text-plugin, css-loader, postcss-loader with postcss-import.
  • It tries to composes with a class from a UI-kit (in my case, fyndiq-component-dropdown).
  • The error happens when fyndiq-component-dropdown tries to import the colors from the same UI kit fyndiq-styles-colors

What is the expected behavior?
It shouldn't break, just like it used to work prior to v0.28.11

Please mention other relevant information such as your webpack version, Node.js version and Operating System.
Webpack 3 (also breaks with Webpack 4)
Node 8.9.1
NPM 5.7.1 (also breaks with NPM 5.8.0)

@alexander-akait
Copy link
Member

Fixed in master, in next version you should use ~fyndiq-component-dropdown/styles.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants