Skip to content
This repository was archived by the owner on Sep 28, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webpack-contrib/eslint-loader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.1
Choose a base ref
...
head repository: webpack-contrib/eslint-loader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.2
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Sep 26, 2019

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    16e9ccf View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7d1d1fe View commit details

Commits on Sep 27, 2019

  1. Copy the full SHA
    fce6f88 View commit details
Showing with 21 additions and 10 deletions.
  1. +8 −0 CHANGELOG.md
  2. +3 −7 package-lock.json
  3. +2 −2 package.json
  4. +8 −1 src/Linter.js
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -2,6 +2,14 @@

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [3.0.2](https://github.com/webpack-contrib/eslint-loader/compare/v3.0.1...v3.0.2) (2019-09-27)


### Bug Fixes

* check if contain results ([#300](https://github.com/webpack-contrib/eslint-loader/issues/300)) ([7d1d1fe](https://github.com/webpack-contrib/eslint-loader/commit/7d1d1fe))
* ensure output file path ([#299](https://github.com/webpack-contrib/eslint-loader/issues/299)) ([16e9ccf](https://github.com/webpack-contrib/eslint-loader/commit/16e9ccf))

### [3.0.1](https://github.com/webpack-contrib/eslint-loader/compare/v3.0.0...v3.0.1) (2019-09-25)


10 changes: 3 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-loader",
"version": "3.0.1",
"version": "3.0.2",
"description": "ESlint loader for webpack",
"license": "MIT",
"repository": "webpack-contrib/eslint-loader",
@@ -38,6 +38,7 @@
"webpack": "^4.0.0"
},
"dependencies": {
"fs-extra": "^8.1.0",
"loader-fs-cache": "^1.0.2",
"loader-utils": "^1.2.3",
"object-hash": "^1.3.1",
@@ -62,7 +63,6 @@
"eslint-config-prettier": "^6.3.0",
"eslint-friendly-formatter": "^4.0.1",
"eslint-plugin-import": "^2.18.2",
"fs-extra": "^8.1.0",
"husky": "^3.0.5",
"jest": "^24.9.0",
"jest-junit": "^8.0.0",
9 changes: 8 additions & 1 deletion src/Linter.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import process from 'process';
import { isAbsolute, join } from 'path';
import { writeFileSync } from 'fs';

import { writeFileSync, ensureFileSync } from 'fs-extra';
import { interpolateName } from 'loader-utils';

import ESLintError from './ESLintError';
@@ -66,6 +66,12 @@ export default class Linter {
}

const results = this.parseResults(res);

// Do not analyze if there are no results or eslint config
if (!results) {
return;
}

const messages = options.formatter(results);

this.reportOutput(results, messages);
@@ -149,6 +155,7 @@ export default class Linter {
);
}

ensureFileSync(filePath);
writeFileSync(filePath, content);
}