Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add globalObject option to modify global context #205

Merged
merged 1 commit into from Mar 9, 2023

Conversation

mabounassif
Copy link
Contributor

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

There are custom JS engines out there that seal the globalThis object. By default, this will break the assignment of the object we want to make global into the global context.

This PR gives the power to the user to override the default and choose the global object of their choosing.

Breaking Changes

There should be no breaking changes.

Additional Info

Addresses #203

@mabounassif
Copy link
Contributor Author

@alexander-akait Brand new PR. Maybe this will work.

@alexander-akait
Copy link
Member

Weird, I really don't undestand why bot doesn't work, because it works for any other repos and PRs

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.25 🎉

Comparison is base (f7a7b42) 82.01% compared to head (868a421) 82.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   82.01%   82.26%   +0.25%     
==========================================
  Files           4        4              
  Lines         139      141       +2     
  Branches       49       51       +2     
==========================================
+ Hits          114      116       +2     
  Misses         16       16              
  Partials        9        9              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait
Copy link
Member

Give me some times I will write report about it and we will fix it soon (today)

@alexander-akait
Copy link
Member

Plese use link directly - https://easycla.lfx.linuxfoundation.org/#/?version=2 and accept CLA, thank you and sorry again

@mabounassif
Copy link
Contributor Author

mabounassif commented Mar 9, 2023

Doesn't seem to have a place to lookup the CLA.
They only support integration with Github.

@alexander-akait
Copy link
Member

Can you try to remove signature from your commit, maybe github doesn't like such commits and don't run bots on it, look at the commit message and next to it you will see Unverified

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mabounassif / name: mahmoud ™ (868a421)

@mabounassif
Copy link
Contributor Author

That was it!
🎉

@alexander-akait alexander-akait merged commit 1ad9096 into webpack-contrib:master Mar 9, 2023
@mabounassif mabounassif deleted the global_object branch March 9, 2023 20:50
@alexander-akait
Copy link
Member

Thank you I will do release right now

@alexander-akait
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants