Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify/improve config usages in readme #60

Closed
WiseBird opened this issue Dec 7, 2017 · 2 comments
Closed

Clarify/improve config usages in readme #60

WiseBird opened this issue Dec 7, 2017 · 2 comments

Comments

@WiseBird
Copy link

WiseBird commented Dec 7, 2017

Readme suggests require.resolve as a way to get path to a module, but webpack's resolution differs from node's one (e.g. webpack supports module property).

Please update readme with info about how to properly get module path.

@aramgre
Copy link

aramgre commented Dec 6, 2019

Is there a straightforward way to resolve the path to the module from the package name? I'm using something like require.resolve('some-package/full/path/to/esm.js') but this is fragile against the package authors changing the directory structure, for example.

It seems difficult because the final webpack resolve.mainFields might not be known when the expose-loader is configured.

@alexander-akait
Copy link
Member

Changing public structure of package is a breaking change and should be done only for major releases, other improvements done in master, feel free to open a new issues if you still have a problems with docs, we will improve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants